Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 1666073002: [turbofan] Remove the function reload hack for OSR. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Work-around safe point Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/linkage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 if (info()->is_osr()) { 1471 if (info()->is_osr()) {
1472 // TurboFan OSR-compiled functions cannot be entered directly. 1472 // TurboFan OSR-compiled functions cannot be entered directly.
1473 __ Abort(kShouldNotDirectlyEnterOsrFunction); 1473 __ Abort(kShouldNotDirectlyEnterOsrFunction);
1474 1474
1475 // Unoptimized code jumps directly to this entrypoint while the unoptimized 1475 // Unoptimized code jumps directly to this entrypoint while the unoptimized
1476 // frame is still on the stack. Optimized code uses OSR values directly from 1476 // frame is still on the stack. Optimized code uses OSR values directly from
1477 // the unoptimized frame. Thus, all that needs to be done is to allocate the 1477 // the unoptimized frame. Thus, all that needs to be done is to allocate the
1478 // remaining stack slots. 1478 // remaining stack slots.
1479 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --"); 1479 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");
1480 osr_pc_offset_ = __ pc_offset(); 1480 osr_pc_offset_ = __ pc_offset();
1481 // TODO(titzer): cannot address target function == local #-1
1482 __ mov(edi, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
1483 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots(); 1481 stack_shrink_slots -= OsrHelper(info()).UnoptimizedFrameSlots();
1484 } 1482 }
1485 1483
1486 const RegList saves = descriptor->CalleeSavedRegisters(); 1484 const RegList saves = descriptor->CalleeSavedRegisters();
1487 if (stack_shrink_slots > 0) { 1485 if (stack_shrink_slots > 0) {
1488 __ sub(esp, Immediate(stack_shrink_slots * kPointerSize)); 1486 __ sub(esp, Immediate(stack_shrink_slots * kPointerSize));
1489 } 1487 }
1490 1488
1491 if (saves != 0) { // Save callee-saved registers. 1489 if (saves != 0) { // Save callee-saved registers.
1492 DCHECK(!info()->is_osr()); 1490 DCHECK(!info()->is_osr());
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
1734 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 1732 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
1735 __ Nop(padding_size); 1733 __ Nop(padding_size);
1736 } 1734 }
1737 } 1735 }
1738 1736
1739 #undef __ 1737 #undef __
1740 1738
1741 } // namespace compiler 1739 } // namespace compiler
1742 } // namespace internal 1740 } // namespace internal
1743 } // namespace v8 1741 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/linkage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698