Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

Issue 1666003002: bluetooth: Add Web Bluetooth blacklist checks to requestDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-
Patch Set: fix test expectation with updated error string Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html
new file mode 100644
index 0000000000000000000000000000000000000000..33527d2906687edb39ac5402b44e836b0899a5e9
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html
@@ -0,0 +1,42 @@
+<!DOCTYPE html>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharness-helpers.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="resources/bluetooth-helpers.js"></script>
+<script>
+'use strict';
+
+test(t => { assert_true(window.testRunner instanceof Object); t.done(); },
+ 'window.testRunner is required for the following tests.');
+
+promise_test(() => {
+ testRunner.setBluetoothMockDataSet('HeartRateAdapter');
+ return assert_promise_rejects_with_message(
+ requestDeviceWithKeyDown(
+ {filters: [{services: ['human_interface_device']}]}),
+ new DOMException(
+ 'requestDevice() called with a filter containing a blacklisted UUID. ' +
+ 'https://goo.gl/4NeimX',
+ 'SecurityError'),
+ 'Requesting blacklisted service rejects.');
+}, 'Reject with SecurityError if requesting a blacklisted service.');
+
+promise_test(() => {
+ testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter');
+ return requestDeviceWithKeyDown(
+ {
+ filters: [{services: ['heart_rate']}],
+ optionalServices: ['human_interface_device']
+ })
+ .then(device => device.gatt.connect())
+ .then(gattServer => {
+ return assert_promise_rejects_with_message(
+ gattServer.getPrimaryService('human_interface_device'),
+ new DOMException(
+ 'Origin is not allowed to access the service. Remember to add the ' +
+ 'service to a filter or to optionalServices in requestDevice().',
+ 'SecurityError'),
+ 'Blacklisted service not accessible.');
+ });
+}, 'Blacklisted UUID in optionalServices is removed and access not granted.');
+</script>

Powered by Google App Engine
This is Rietveld 408576698