third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html - Issue 1666003002: bluetooth: Add Web Bluetooth blacklist checks to requestDevice.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice-blacklist.html

Issue 1666003002: bluetooth: Add Web Bluetooth blacklist checks to requestDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-blacklist-

Patch Set: fix test expectation with updated error string Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharness-helpers.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="resources/bluetooth-helpers.js"></script>

	6 <script>

	7 'use strict';

	8

	9 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },

	10 'window.testRunner is required for the following tests.');

	11

	12 promise_test(() => {

	13 testRunner.setBluetoothMockDataSet('HeartRateAdapter');

	14 return assert_promise_rejects_with_message(

	15 requestDeviceWithKeyDown(

	16 {filters: [{services: ['human_interface_device']}]}),

	17 new DOMException(

	18 'requestDevice() called with a filter containing a blacklisted UUID. ' +

	19 'https://goo.gl/4NeimX',

	20 'SecurityError'),

	21 'Requesting blacklisted service rejects.');

	22 }, 'Reject with SecurityError if requesting a blacklisted service.');

	23

	24 promise_test(() => {

	25 testRunner.setBluetoothMockDataSet('HeartRateAndHIDAdapter');

	26 return requestDeviceWithKeyDown(

	27 {

	28 filters: [{services: ['heart_rate']}],

	29 optionalServices: ['human_interface_device']

	30 })

	31 .then(device => device.gatt.connect())

	32 .then(gattServer => {

	33 return assert_promise_rejects_with_message(

	34 gattServer.getPrimaryService('human_interface_device'),

	35 new DOMException(

	36 'Origin is not allowed to access the service. Remember to add the ' +

	37 'service to a filter or to optionalServices in requestDevice().',

	38 'SecurityError'),

	39 'Blacklisted service not accessible.');

	40 });

	41 }, 'Blacklisted UUID in optionalServices is removed and access not granted.');

	42 </script>

OLD	NEW