Issue 1665993002: Prefer Dart_SetReturnValue over Dart_PropagateError when it makes sense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1665993002: Prefer Dart_SetReturnValue over Dart_PropagateError when it makes sense. (Closed)

Created:
4 years, 10 months ago by turnidge

Modified:
4 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -142 lines)			Patch
M	runtime/bin/directory.cc	View	7 chunks	+7 lines, -21 lines	0 comments	Download
M	runtime/bin/file.cc	View	30 chunks	+33 lines, -100 lines	0 comments	Download
M	runtime/bin/file_system_watcher.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/bin/process.cc	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	runtime/bin/socket.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/bin/stdio.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

turnidge

4 years, 10 months ago (2016-02-03 23:41:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e3643f4459df4bb02a847fce3fb0fdf7343e1d3 (presubmit successful).