Prefer Dart_SetReturnValue over Dart_PropagateError when it makes sense.

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/log.h"
 #include "bin/platform.h"
 #include "bin/process.h"
 #include "bin/socket.h"
@@ skipping 170 matching lines @@
         status_handle, "_errorCode", error_code);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     result = DartUtils::SetStringField(
         status_handle,
         "_errorMessage",
         os_error_message != NULL ? os_error_message
                                  : "Cannot get error message");
     if (Dart_IsError(result)) {
+      delete[] string_args;
+      delete[] string_environment;
+      free(os_error_message);
       Dart_PropagateError(result);
     }
   }
   delete[] string_args;
   delete[] string_environment;
   free(os_error_message);
   Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
 }
 
 
@@ skipping 22 matching lines @@
     if (Dart_IsError(err)) Dart_PropagateError(err);
     Dart_Handle list = Dart_NewList(4);
     Dart_ListSetAt(list, 0, Dart_NewInteger(pid));
     Dart_ListSetAt(list, 1, Dart_NewInteger(result.exit_code()));
     Dart_ListSetAt(list, 2, out);
     Dart_ListSetAt(list, 3, err);
     Dart_SetReturnValue(args, list);
   } else {
     Dart_Handle error = DartUtils::NewDartOSError();
     Process::Kill(pid, 9);
-    if (Dart_IsError(error)) Dart_PropagateError(error);
     Dart_ThrowException(error);
   }
 }
 
 
 void FUNCTION_NAME(Process_KillPid)(Dart_NativeArguments args) {
   intptr_t pid = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
   intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 1));
   bool success = Process::Kill(pid, signal);
   Dart_SetReturnValue(args, Dart_NewBoolean(success));
@@ skipping 89 matching lines @@
           reinterpret_cast<char*>(buffer),
           bytes_length,
           &len);
   if (str == NULL) {
     Dart_ThrowException(
         DartUtils::NewInternalError("SystemEncodingToString failed"));
   }
   result =
       Dart_NewStringFromUTF8(reinterpret_cast<const uint8_t*>(str), len);
   free(str);
-  if (Dart_IsError(result)) Dart_PropagateError(result);
   Dart_SetReturnValue(args, result);
 }
 
 
 void FUNCTION_NAME(StringToSystemEncoding)(Dart_NativeArguments args) {
   Dart_Handle str = Dart_GetNativeArgument(args, 0);
   char* utf8;
   intptr_t utf8_len;
   Dart_Handle result = Dart_StringToUTF8(
       str, reinterpret_cast<uint8_t **>(&utf8), &utf8_len);
   if (Dart_IsError(result)) {
     Dart_PropagateError(result);
   }
   intptr_t system_len;
   const char* system_string =
       StringUtils::Utf8ToConsoleString(utf8, utf8_len, &system_len);
   if (system_string == NULL) {
     Dart_ThrowException(
         DartUtils::NewInternalError("StringToSystemEncoding failed"));
   }
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(system_len, &buffer);
-  if (Dart_IsError(external_array)) {
-    free(const_cast<char*>(system_string));
-    Dart_PropagateError(result);
+  if (!Dart_IsError(external_array)) {
+    memmove(buffer, system_string, system_len);
   }
-  memmove(buffer, system_string, system_len);
+  Dart_SetReturnValue(args, external_array);
   free(const_cast<char*>(system_string));
-  Dart_SetReturnValue(args, external_array);
 }
 
 }  // namespace bin
 }  // namespace dart