Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 166573006: Use "e" constraint in place of "i" to match x86_64_general_operand (Closed)

Created:
6 years, 10 months ago by Roland McGrath
Modified:
6 years, 10 months ago
Reviewers:
khim, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Use "e" constraint in place of "i" to match x86_64_general_operand The fix for bug 3549 (commit d913bb7) was incomplete. When the x86_64_general_operand predicate is used, the corresponding operand constraint must be "e" rather than "i". The predicate controls only whether the instruction pattern is selected in initial RTL generation. The constraint controls how operands can be replaced by later phases of the compiler, such as the "reload" steps done by register allocation. The "i" constraint accepts a SYMBOL_REF under -fPIC while "e" does not. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3793 TEST= toolchain trybots R=sehr@chromium.org, khim@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=093bbb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M gcc/config/i386/i386.md View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
6 years, 10 months ago (2014-02-14 22:56:23 UTC) #1
sehr
I'm going to trust you on this one, as the tools don't let me read ...
6 years, 10 months ago (2014-02-20 17:28:52 UTC) #2
Roland McGrath
6 years, 10 months ago (2014-02-20 17:32:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r093bbb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698