chrome/test/data/extensions/api_test/permissions/optional/background.js - Issue 1665563003: Ask for notification permission during extension installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/permissions/optional/background.js

Issue 1665563003: Ask for notification permission during extension installation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/test/data/extensions/api_test/permissions/optional/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/permissions/optional/background.js

diff --git a/chrome/test/data/extensions/api_test/permissions/optional/background.js b/chrome/test/data/extensions/api_test/permissions/optional/background.js

index e0c2f64d4ee16d753a508b0a6a725dd19463b88c..2bf1e17b254872dd0f2489ead96c4565b05c9347 100644

--- a/chrome/test/data/extensions/api_test/permissions/optional/background.js

+++ b/chrome/test/data/extensions/api_test/permissions/optional/background.js

@@ -206,13 +206,13 @@ chrome.test.getConfig(function(config) {

// The user shouldn't have to approve permissions that have no warnings.

function noPromptForNoWarnings() {

chrome.permissions.request(

- {permissions: ['notifications']},

+ {permissions: ['cookies']},

pass(function(granted) {

assertTrue(granted);

- // Remove the notifications permission to return to normal.

+ // Remove the cookies permission to return to normal.

chrome.permissions.remove(

- {permissions: ['notifications']},

+ {permissions: ['cookies']},

pass(function(removed) { assertTrue(removed); }));

}));