chrome/common/extensions/permissions/permission_set_unittest.cc - Issue 1665563003: Ask for notification permission during extension installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1665563003: Ask for notification permission during extension installation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/common/extensions/permissions/chrome_permission_message_rules.cc ('k') | chrome/test/data/extensions/api_test/permissions/optional/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set_unittest.cc

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc

index f939f1eb029e59af6dc7480a4f6d4d0af699bdae..8617b5d8c8c884aadf49af9149974dce891989de 100644

--- a/chrome/common/extensions/permissions/permission_set_unittest.cc

+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc

@@ -685,7 +685,7 @@ TEST(PermissionsTest, IsPrivilegeIncrease) {

{ "plugin3", true }, // none -> plugin

#endif

{ "storage", false }, // none -> storage

- { "notifications", false }, // none -> notifications

+ { "notifications", true }, // none -> notifications

{ "platformapp1", false }, // host permissions for platform apps

{ "platformapp2", true }, // API permissions for platform apps

{ "media_galleries1", true }, // all -> read|all

@@ -758,7 +758,6 @@ TEST(PermissionsTest, PermissionMessages) {

skip.insert(APIPermission::kInlineInstallPrivate);

skip.insert(APIPermission::kIdltest);

skip.insert(APIPermission::kLogPrivate);

- skip.insert(APIPermission::kNotifications);

skip.insert(APIPermission::kNotificationProvider);

skip.insert(APIPermission::kOverrideEscFullscreen);

skip.insert(APIPermission::kPointerLock);