third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1665533003: Set the request mode and the credentials mode of FetchEvent in the service worker correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1665533003: Set the request mode and the credentials mode of FetchEvent in the service worker correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/ImageLoader.cpp ('k') | third_party/WebKit/Source/platform/network/ResourceRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index 6d563050f642adf9cc2ad430112cfbb30c7c561e..6fe0bdeff7e53fce6cf27c6a9aa0c7d99f828a50 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -526,6 +526,8 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

ResourceRequest request(m_request->url());

request.setRequestContext(m_request->context());

request.setHTTPMethod(m_request->method());

+ request.setFetchRequestMode(m_request->mode());

+ request.setFetchCredentialsMode(m_request->credentials());

const Vector<OwnPtr<FetchHeaderList::Header>>& list = m_request->headerList()->list();

for (size_t i = 0; i < list.size(); ++i) {

request.addHTTPHeaderField(AtomicString(list[i]->first), AtomicString(list[i]->second));