third_party/WebKit/Source/core/loader/ImageLoader.cpp - Issue 1665533003: Set the request mode and the credentials mode of FetchEvent in the service worker correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.cpp

Issue 1665533003: Set the request mode and the credentials mode of FetchEvent in the service worker correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ImageLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.cpp b/third_party/WebKit/Source/core/loader/ImageLoader.cpp

index 94ba386124afa45fe0aa71ff48e95444b5916242..f2d09087f1b9f704f3cfe451de7ee103b8bfa06c 100644

--- a/third_party/WebKit/Source/core/loader/ImageLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/ImageLoader.cpp

@@ -316,7 +316,6 @@ void ImageLoader::doUpdateFromElement(BypassMainWorldBehavior bypassBehavior, Up

// Unlike raw <img>, we block mixed content inside of <picture> or <img srcset>.

ResourceLoaderOptions resourceLoaderOptions = ResourceFetcher::defaultResourceOptions();

ResourceRequest resourceRequest(url);

- resourceRequest.setFetchCredentialsMode(WebURLRequest::FetchCredentialsModeSameOrigin);

if (updateBehavior == UpdateForcedReload) {

resourceRequest.setCachePolicy(ResourceRequestCachePolicy::ReloadBypassingCache);

resourceRequest.setLoFiState(WebURLRequest::LoFiOff);