ipc/ipc_message_macros.h - Issue 1665363002: Clang plugin to check that unstable types are not used in IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_macros.h

Issue 1665363002: Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Blacklist types instead Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_macros.h

diff --git a/ipc/ipc_message_macros.h b/ipc/ipc_message_macros.h

index a573265bd2b14bf0eeffb736a1c688ab2b6e3b59..71c8e4fc420a9f5ca22553e26aa67c683ad988d5 100644

--- a/ipc/ipc_message_macros.h

+++ b/ipc/ipc_message_macros.h

@@ -248,7 +248,7 @@

#define IPC_SYNC_MESSAGE_ROUTED(msg_class, in, out) \

IPC_MESSAGE_DECL(msg_class, ROUTED, IPC_TUPLE in, IPC_TUPLE out)

-#define IPC_TUPLE(...) base::Tuple<__VA_ARGS__>

+#define IPC_TUPLE(...) IPC::CheckedTuple<__VA_ARGS__>::Tuple

#define IPC_MESSAGE_DECL(msg_name, kind, in_tuple, out_tuple) \

struct IPC_MESSAGE_EXPORT msg_name##_Meta { \

« no previous file with comments | « chrome/common/safe_browsing/protobuf_message_param_traits.h ('k') | ipc/ipc_message_templates.h » ('j') | ipc/ipc_message_utils.h » ('J')