ipc/ipc_message_templates.h - Issue 1665363002: Clang plugin to check that unstable types are not used in IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_templates.h

Issue 1665363002: Clang plugin to check that unstable types are not used in IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Blacklist types instead Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_templates.h

diff --git a/ipc/ipc_message_templates.h b/ipc/ipc_message_templates.h

index 17dfc1b9ff221169167c2f3103089a219e14fa5e..343bff73cfaa9df87a18bf9fdd5822c4347bf805 100644

--- a/ipc/ipc_message_templates.h

+++ b/ipc/ipc_message_templates.h

@@ -167,7 +167,7 @@ class MessageT<Meta, base::Tuple<Ins...>, base::Tuple<Outs...>>

if (ok) {

ReplyParam reply_params;

base::DispatchToMethod(obj, func, send_params, &reply_params);

- WriteParam(reply, reply_params);

+ WriteParamUnchecked(reply, reply_params);

LogReplyParamsToMessage(reply_params, msg);

} else {

NOTREACHED() << "Error deserializing message " << msg->type();

« no previous file with comments | « ipc/ipc_message_macros.h ('k') | ipc/ipc_message_templates_impl.h » ('j') | ipc/ipc_message_utils.h » ('J')