src/IceAssemblerX86BaseImpl.h - Issue 1665263003: Subzero. ARM32. Nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX86BaseImpl.h

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceAssemblerX86BaseImpl.h

diff --git a/src/IceAssemblerX86BaseImpl.h b/src/IceAssemblerX86BaseImpl.h

index 00856caefba8845423584112f24903efbdf3a6a5..19cd99c511ac14212667a15e7b41ef05e86c5044 100644

--- a/src/IceAssemblerX86BaseImpl.h

+++ b/src/IceAssemblerX86BaseImpl.h

@@ -106,13 +106,6 @@ void AssemblerX86Base<TraitsType>::bindLocalLabel(SizeT Number) {

}

template <typename TraitsType>

-void AssemblerX86Base<TraitsType>::bindRelocOffset(RelocOffset *Offset) {

- if (!getPreliminary()) {

- Offset->setOffset(Buffer.getPosition());

- }

-template <typename TraitsType>

void AssemblerX86Base<TraitsType>::call(GPRRegister reg) {

AssemblerBuffer::EnsureCapacity ensured(&Buffer);

emitRexB(RexTypeIrrelevant, reg);

« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceCfg.h » ('j') | no next file with comments »