src/IceAssemblerX86Base.h - Issue 1665263003: Subzero. ARM32. Nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX86Base.h

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceAssemblerX86Base.h

diff --git a/src/IceAssemblerX86Base.h b/src/IceAssemblerX86Base.h

index ca65c0f7ed8648e7c5c9a77ca38d3170e75d6710..265085db942294bc58d5cb2ec462eba24cdac6ff 100644

--- a/src/IceAssemblerX86Base.h

+++ b/src/IceAssemblerX86Base.h

@@ -167,7 +167,6 @@ public:

Label *getOrCreateCfgNodeLabel(SizeT Number);

Label *getOrCreateLocalLabel(SizeT Number);

void bindLocalLabel(SizeT Number);

- void bindRelocOffset(RelocOffset *Offset);

bool fixupIsPCRel(FixupKind Kind) const override {

// Currently assuming this is the only PC-rel relocation type used.

« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceAssemblerX86BaseImpl.h » ('j') | no next file with comments »