runtime/szrt_asm_arm32.s - Issue 1665263003: Subzero. ARM32. Nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/szrt_asm_arm32.s

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: git pull Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/szrt_asm_arm32.s

diff --git a/runtime/szrt_asm_arm32.s b/runtime/szrt_asm_arm32.s

index 1d01909530705ad72e603c4a9198eca186908b74..54cb380a73b6e3eb96008e5bceb2586822a7aaf8 100644

--- a/runtime/szrt_asm_arm32.s

+++ b/runtime/szrt_asm_arm32.s

@@ -14,3 +14,6 @@

.text

.p2alignl 4,0xE7FEDEF0

+ .globl __nacl_read_tp

+__nacl_read_tp:

+ b __aeabi_read_tp

Jim Stichnoth 2016/02/10 06:35:59 Optional: This tailcall is simple and all, but I w

John 2016/02/10 15:41:13 Not as far as I could find. I wonder, should the T

Jim Stichnoth 2016/02/10 17:00:21 Yeah, I think we could directly call __aeabi_read_

John 2016/02/10 23:38:21 Done.