runtime/szrt_asm_arm32.s - Issue 1665263003: Subzero. ARM32. Nonsfi.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/szrt_asm_arm32.s

Issue 1665263003: Subzero. ARM32. Nonsfi. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: git pull Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 ##===- subzero/runtime/szrt_asm_arm32.s - Subzero runtime asm helpers------===##	1 ##===- subzero/runtime/szrt_asm_arm32.s - Subzero runtime asm helpers------===##

2 ##	2 ##

3 ## The Subzero Code Generator	3 ## The Subzero Code Generator

4 ##	4 ##

5 ## This file is distributed under the University of Illinois Open Source	5 ## This file is distributed under the University of Illinois Open Source

6 ## License. See LICENSE.TXT for details.	6 ## License. See LICENSE.TXT for details.

7 ##	7 ##

8 ##===----------------------------------------------------------------------===##	8 ##===----------------------------------------------------------------------===##

9 ##	9 ##

10 ## This file provides an assembly implementation of various helpers needed by	10 ## This file provides an assembly implementation of various helpers needed by

11 ## the Subzero arm32 runtime.	11 ## the Subzero arm32 runtime.

12 ##	12 ##

13 ##===----------------------------------------------------------------------===##	13 ##===----------------------------------------------------------------------===##

14	14

15 .text	15 .text

16 .p2alignl 4,0xE7FEDEF0	16 .p2alignl 4,0xE7FEDEF0

	17 .globl __nacl_read_tp

	18 __nacl_read_tp:

	19 b __aeabi_read_tp
	Jim Stichnoth 2016/02/10 06:35:59 Optional: This tailcall is simple and all, but I w Optional: This tailcall is simple and all, but I wonder if there is some asm magic that could tell the linker in this file just to substitute the value of __aeabi_read_tp for __nacl_read_tp . John 2016/02/10 15:41:13 Not as far as I could find. I wonder, should the T Show quoted text On 2016/02/10 06:35:59, stichnot wrote: > Optional: This tailcall is simple and all, but I wonder if there is some asm > magic that could tell the linker in this file just to substitute the value of > __aeabi_read_tp for __nacl_read_tp . Not as far as I could find. I wonder, should the TargetLowering generate a call to __aeabi_read_tp directly? Jim Stichnoth 2016/02/10 17:00:21 Yeah, I think we could directly call __aeabi_read_ Show quoted text On 2016/02/10 15:41:13, John wrote: > On 2016/02/10 06:35:59, stichnot wrote: > > Optional: This tailcall is simple and all, but I wonder if there is some asm > > magic that could tell the linker in this file just to substitute the value of > > __aeabi_read_tp for __nacl_read_tp . > > Not as far as I could find. I wonder, should the TargetLowering generate a call > to __aeabi_read_tp directly? Yeah, I think we could directly call __aeabi_read_tp. If you do, please document it in runtime/szrt.c . John 2016/02/10 23:38:21 Done. Show quoted text On 2016/02/10 17:00:21, stichnot wrote: > On 2016/02/10 15:41:13, John wrote: > > On 2016/02/10 06:35:59, stichnot wrote: > > > Optional: This tailcall is simple and all, but I wonder if there is some asm > > > magic that could tell the linker in this file just to substitute the value > of > > > __aeabi_read_tp for __nacl_read_tp . > > > > Not as far as I could find. I wonder, should the TargetLowering generate a > call > > to __aeabi_read_tp directly? > > Yeah, I think we could directly call __aeabi_read_tp. > > If you do, please document it in runtime/szrt.c . Done.
OLD	NEW

« pydir/build-runtime.py ('K') | « pydir/crosstest_generator.py ('k') | src/IceAssembler.h » ('j') | src/IceCfg.h » ('J')