Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1665043002: Remove is_parenthesized bit from Expression and PreParserExpression (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@simplify-parsing-result
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove is_parenthesized bit from Expression and PreParserExpression This bit was ostensibly being used to provide appropriate syntax errors for invalid destructuring assignment patterns, but adding a single call to RecordPatternError() (in place of BindingPatternUnexpectedToken()) seems to have replaced the need for it. Committed: https://crrev.com/1c318a9e4c5d379f78e48062e7a1b0be122d6f56 Cr-Commit-Position: refs/heads/master@{#33750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M src/ast/ast.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/parsing/parser-base.h View 4 chunks +4 lines, -9 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
adamk
Caitlin, am I missing something here? This appears to pass all tests...
4 years, 10 months ago (2016-02-04 00:09:37 UTC) #2
caitp (gmail)
On 2016/02/04 00:09:37, adamk wrote: > Caitlin, am I missing something here? This appears to ...
4 years, 10 months ago (2016-02-04 02:02:23 UTC) #3
caitp (gmail)
On 2016/02/04 02:02:23, caitp wrote: > On 2016/02/04 00:09:37, adamk wrote: > > Caitlin, am ...
4 years, 10 months ago (2016-02-04 02:03:32 UTC) #4
caitp (gmail)
lgtm
4 years, 10 months ago (2016-02-04 02:12:27 UTC) #5
rossberg
LGTM. A left-over from the pre-ExpressionClassifier days.
4 years, 10 months ago (2016-02-04 13:33:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1665043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1665043002/1
4 years, 10 months ago (2016-02-04 18:52:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 18:53:54 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 18:54:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c318a9e4c5d379f78e48062e7a1b0be122d6f56
Cr-Commit-Position: refs/heads/master@{#33750}

Powered by Google App Engine
This is Rietveld 408576698