Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 1661193002: Remove unused 'needs_init' member of ParsingResult (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused 'needs_init' member of ParsingResult Also various related cleanup in ParseVariableDeclarations(). The only changes in logic are explained below: - We were redundantly checking for parenthesized binding patterns; these are already ruled out by BindingPatternUnexpectedToken() calls in the places where we hit an LPAREN. - There's no need to default-initialize a LET-mode variable in a for-each loop, just as there isn't for CONST or CONST_LEGACY (ParseForStatement will take care of properly initializing all of the above). Committed: https://crrev.com/3d56b0d7c03690627a74125869636e621b7ae8dd Cr-Commit-Position: refs/heads/master@{#33749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -45 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 8 chunks +20 lines, -37 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +2 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
adamk
4 years, 10 months ago (2016-02-03 23:32:03 UTC) #2
adamk
This patch also caused me to question whether we really needed the is_parenthesized bit, and ...
4 years, 10 months ago (2016-02-04 00:14:07 UTC) #3
rossberg
Nice, lgtm.
4 years, 10 months ago (2016-02-04 13:30:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661193002/1
4 years, 10 months ago (2016-02-04 18:42:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 18:44:01 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 18:44:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d56b0d7c03690627a74125869636e621b7ae8dd
Cr-Commit-Position: refs/heads/master@{#33749}

Powered by Google App Engine
This is Rietveld 408576698