GN: Set -fstack-protector for arm64 to match GYP

GN: Set -fstack-protector for arm64 to match GYP

BUG=None

Committed: https://crrev.com/d3d8cfdb47fe445ae23f6eafc90f977e6f50a8b9
Cr-Commit-Position: refs/heads/master@{#373563}

[pkotwicz, 2016-02-04 01:32:19]

Description was changed from

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None
==========

to

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None
==========

[pkotwicz, 2016-02-04 01:32:19]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2016-02-04 01:33:10]

agrieve@ PTAL.

The GN logic landed in https://codereview.chromium.org/1258923012 I do not
understand why it is the way it is

[agrieve, 2016-02-04 02:15:47]

lgtm

https://codereview.chromium.org/1664693004/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (left):

https://codereview.chromium.org/1664693004/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:166: if (is_android && (current_cpu == "arm64" ||
current_cpu == "x86")) {
Hmm, yeah, i got nothing :(.

Could you also add the comment from common.gypi:

# The x86 toolchain currently has problems with stack-protector.

[pkotwicz, 2016-02-04 16:56:03]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-02-04 16:56:03]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1664693004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-04 16:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664693004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664693004/20001

[commit-bot: I haz the power, 2016-02-04 18:09:55]

Description was changed from

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None
==========

to

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None
==========

[commit-bot: I haz the power, 2016-02-04 18:09:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-04 18:11:55]

Description was changed from

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None
==========

to

==========
GN: Set -fstack-protector for arm64 to match GYP

BUG=None

Committed: https://crrev.com/d3d8cfdb47fe445ae23f6eafc90f977e6f50a8b9
Cr-Commit-Position: refs/heads/master@{#373563}
==========

[commit-bot: I haz the power, 2016-02-04 18:11:55]

Patchset 2 (id:??) landed as
https://crrev.com/d3d8cfdb47fe445ae23f6eafc90f977e6f50a8b9
Cr-Commit-Position: refs/heads/master@{#373563}