Improve clarity of Physical Web opt-in notification

Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541
Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}

[mattreynolds, 2016-02-03 21:34:23]

mattreynolds@chromium.org changed reviewers:
+ newt@chromium.org

[mattreynolds, 2016-02-03 21:34:23]

Hi newt, PTAL.

[newt (away), 2016-02-03 21:57:29]

Re: images
 - We can't check the Chrome logo into Chromium. Only Chromium logos live in
Chromium. Chrome logos live in an internal repository and get added at build
time on branded builds
 - We've already got copies of the Chromium/Chrome/Chrome Beta/etc logos
available: look for all the different app_icon.png files. It'd be best if you
can just reuse this image rather than adding more.

https://codereview.chromium.org/1664673003/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1664673003/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:2327: <message
name="IDS_PHYSICAL_WEB_OPTIN_NOTIFICATION_TEXT" desc="The second line in a
notification message inviting the user to opt-in to the Physical Web.">
I'm not sure this description give enough context for translators to understand
the string. In particular, translators probably won't understand what "them"
refers to.

[mattreynolds, 2016-02-03 22:40:56]

I removed the icons and pointed it at R.mipmap.app_icon which gets the Clankium
icon in my local build, I assume this is the one that gets replaced for other
builds?

https://codereview.chromium.org/1664673003/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1664673003/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:2327: <message
name="IDS_PHYSICAL_WEB_OPTIN_NOTIFICATION_TEXT" desc="The second line in a
notification message inviting the user to opt-in to the Physical Web.">
On 2016/02/03 21:57:28, newt wrote:
> I'm not sure this description give enough context for translators to
understand
> the string. In particular, translators probably won't understand what "them"
> refers to.

Done.

[newt (away), 2016-02-03 22:50:49]

On 2016/02/03 22:40:56, mattreynolds wrote:
> I removed the icons and pointed it at R.mipmap.app_icon which gets the
Clankium
> icon in my local build, I assume this is the one that gets replaced for other
> builds?

Exactly.

lgtm :)

[mattreynolds, 2016-02-03 22:52:23]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2016-02-03 22:53:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664673003/20001

[commit-bot: I haz the power, 2016-02-03 23:48:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-03 23:50:02]

Description was changed from

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541
==========

to

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541

Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}
==========

[commit-bot: I haz the power, 2016-02-03 23:50:03]

Patchset 2 (id:??) landed as
https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}

[cco3, 2016-02-08 21:48:30]

Description was changed from

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541

Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}
==========

to

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541
BUG=585228

Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}
==========

[cco3, 2016-02-08 21:49:41]

Description was changed from

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541
BUG=585228

Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}
==========

to

==========
Improve clarity of Physical Web opt-in notification

The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.

BUG=583541

Committed: https://crrev.com/02432cab3b500ba797b9ecfc67e10d0e1ce9be8f
Cr-Commit-Position: refs/heads/master@{#373389}
==========