Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 1664673003: Improve clarity of Physical Web opt-in notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use app_icons, improve string descriptions Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
index d99a59de9f15ad84c5f2cf4bae447ef2e5ba9feb..0a7be12ca6520359c80490dc4e4057ae9b928835 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
@@ -398,14 +398,15 @@ class UrlManager {
// Get values to display.
Resources resources = mContext.getResources();
String title = resources.getString(R.string.physical_web_optin_notification_title);
- Bitmap largeIcon = BitmapFactory.decodeResource(resources,
- R.drawable.physical_web_notification_large);
+ String text = resources.getString(R.string.physical_web_optin_notification_text);
+ Bitmap largeIcon = BitmapFactory.decodeResource(resources, R.mipmap.app_icon);
// Create the notification.
Notification notification = new NotificationCompat.Builder(mContext)
.setLargeIcon(largeIcon)
- .setSmallIcon(R.drawable.ic_chrome)
+ .setSmallIcon(R.drawable.ic_physical_web_notification)
.setContentTitle(title)
+ .setContentText(text)
.setContentIntent(pendingIntent)
.setPriority(priority)
.setVisibility(NotificationCompat.VISIBILITY_PUBLIC)
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698