Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664663003: extend compose-colorfilter to 4f (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update gm #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M gm/color4f.cpp View 1 2 3 chunks +16 lines, -3 lines 0 comments Download
M include/core/SkColor.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkColor.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/core/SkColorFilter.cpp View 3 chunks +20 lines, -3 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664663003/20001
4 years, 10 months ago (2016-02-04 17:04:46 UTC) #3
reed1
4 years, 10 months ago (2016-02-04 17:05:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664663003/40001
4 years, 10 months ago (2016-02-04 17:12:47 UTC) #7
mtklein
lgtm https://codereview.chromium.org/1664663003/diff/40001/src/core/SkColorFilter.cpp File src/core/SkColorFilter.cpp (right): https://codereview.chromium.org/1664663003/diff/40001/src/core/SkColorFilter.cpp#newcode46 src/core/SkColorFilter.cpp:46: SkColor4f SkColorFilter::filterColor4f(const SkColor4f& c) const { Ouch. This ...
4 years, 10 months ago (2016-02-04 17:35:49 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 17:48:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664663003/40001
4 years, 10 months ago (2016-02-04 19:34:53 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 19:35:31 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f7cdb06d62bd732599c7ee407dfd76d32d671755

Powered by Google App Engine
This is Rietveld 408576698