Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1664663002: Revert of Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall (Closed)

Created:
4 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, cwallez
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall (patchset #6 id:100001 of https://codereview.chromium.org/1654183002/ ) Reason for revert: Still failing compilation. See for example: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53615 ninja -w dupbuild=err -C /b/build/slave/GPU_Linux_Builder/build/src/out/Release angle_deqp_gles2_tests angle_deqp_gles2_tests_run angle_deqp_gles3_tests angle_deqp_gles3_tests_run angle_end2end_tests angle_end2end_tests_run angle_unittests angle_unittests_run audio_unittests audio_unittests_run browser_tests content_gl_tests content_gl_tests_run gl_tests gl_tests_run gl_unittests gl_unittests_run gles2_conform_test gles2_conform_test_run tab_capture_end2end_tests_run telemetry_gpu_test_run -j50 ninja: Entering directory `/b/build/slave/GPU_Linux_Builder/build/src/out/Release' ninja: error: unknown target 'angle_deqp_gles2_tests_run' Original issue's description: > Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall > > BUG=580045 > TBR=dpranke@chromium.org > NOTRY=true > > Committed: https://crrev.com/905db95f877347cf0fba0f5847e8069c5985d331 > Cr-Commit-Position: refs/heads/master@{#373108} TBR=dpranke@chromium.org,cwallez@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580045 Committed: https://crrev.com/7020b17a43baeb739cf46c861d49ea32a57247db Cr-Commit-Position: refs/heads/master@{#373191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -56 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 3 chunks +6 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 2 chunks +1 line, -30 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ken Russell (switch to Gerrit)
Created Revert of Re-enable the ANGLE dEQP tests on Linux on the GPU FYI waterfall
4 years, 10 months ago (2016-02-03 07:24:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664663002/1
4 years, 10 months ago (2016-02-03 07:24:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 07:25:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7020b17a43baeb739cf46c861d49ea32a57247db Cr-Commit-Position: refs/heads/master@{#373191}
4 years, 10 months ago (2016-02-03 07:26:43 UTC) #6
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-03 16:39:55 UTC) #7
Corentin Wallez
On 2016/02/03 at 16:39:55, dpranke wrote: > lgtm Thanks for reverting this. If I understand ...
4 years, 10 months ago (2016-02-03 17:08:57 UTC) #8
Ken Russell (switch to Gerrit)
4 years, 10 months ago (2016-02-03 17:10:41 UTC) #9
Message was sent while issue was closed.
On 2016/02/03 17:08:57, Corentin Wallez wrote:
> On 2016/02/03 at 16:39:55, dpranke wrote:
> > lgtm
> 
> Thanks for reverting this. If I understand correctly, the patch should work
once
> https://codereview.chromium.org/1653003006 is relanded?

I think they're unrelated problems, but am not sure. Please re-test and try to
re-land this once http://crbug.com/583694 is resolved.

Powered by Google App Engine
This is Rietveld 408576698