Move gn _run target generation into test().

Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
Cr-Commit-Position: refs/heads/master@{#373232}

[jbudorick, 2016-02-02 16:05:15]

Description was changed from

==========
Move gn _run target generation into test().

BUG=
==========

to

==========
Move gn _run target generation into test().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbudorick, 2016-02-02 16:06:09]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org

[jbudorick, 2016-02-02 16:07:57]

jbudorick@chromium.org changed reviewers:
+ phosek@chromium.org

[jbudorick, 2016-02-02 16:07:58]

also +phosek for components/nacl/loader/BUILD.gn, as that one was particularly
weird.

[Petr Hosek, 2016-02-02 22:39:59]

components/nacl/loader/BUILD.gn lgtm

[Dirk Pranke, 2016-02-02 23:21:28]

LGTM !

Excellent, thanks for working on this.

[Dirk Pranke, 2016-02-02 23:22:01]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2016-02-02 23:22:01]

TBR'ing brettw@ for the recursive approval as well ...

[Dirk Pranke, 2016-02-02 23:22:16]

Description was changed from

==========
Move gn _run target generation into test().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brettw, 2016-02-02 23:38:45]

lgtm

[jbudorick, 2016-02-03 01:06:01]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-02-03 01:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653003006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653003006/1

[commit-bot: I haz the power, 2016-02-03 01:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 01:31:14]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[jbudorick, 2016-02-03 14:16:12]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-02-03 14:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653003006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653003006/1

[commit-bot: I haz the power, 2016-02-03 14:35:18]

Description was changed from

==========
Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-03 14:35:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-03 14:37:07]

Description was changed from

==========
Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Move gn _run target generation into test().

TBR=brettw@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
Cr-Commit-Position: refs/heads/master@{#373232}
==========

[commit-bot: I haz the power, 2016-02-03 14:37:09]

Patchset 1 (id:??) landed as
https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a
Cr-Commit-Position: refs/heads/master@{#373232}

[Dirk Pranke, 2016-02-03 16:55:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1664653003/ by dpranke@chromium.org.

The reason for reverting is: Broke angle_unittests_run, which doesn't follow the
template:

https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/....

[tfarina, 2016-02-03 21:05:25]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2016-02-03 21:05:26]

When you reland this, could you add to the CL description the reason for you to
be doing this? As I reader and not familiar with run() target I have no idea why
it has to be moved into test() template. I believe this is for Android only? I
don't think it will hurt you if you give a bit more of context for the future
readers years from now. ;)

[jbudorick, 2016-02-03 21:39:59]

On 2016/02/03 21:05:26, tfarina wrote:
> When you reland this, could you add to the CL description the reason for you
to
> be doing this? As I reader and not familiar with run() target I have no idea
why
> it has to be moved into test() template. I believe this is for Android only? I
> don't think it will hurt you if you give a bit more of context for the future
> readers years from now. ;)

This is for desktop. It's simply consolidating existing _run targets into one
place. The _run targets don't _have_ to be moved into the test template, but
they're easier to maintain if they're implemented in one place inside the
template instead of in dozens of places across the repository. I'll add a note
to the reland description (https://codereview.chromium.org/1662053002/)

[Dirk Pranke, 2016-02-03 22:27:49]

On 2016/02/03 21:39:59, jbudorick wrote:
> On 2016/02/03 21:05:26, tfarina wrote:
> > When you reland this, could you add to the CL description the reason for you
> to
> > be doing this? As I reader and not familiar with run() target I have no idea
> why
> > it has to be moved into test() template. I believe this is for Android only?
I
> > don't think it will hurt you if you give a bit more of context for the
future
> > readers years from now. ;)

They're for both desktop and android; technically, and we provide the targets
for compatibility w/ GYP (and the buildbot scripts that need them to exist),
but the targets are useless in GN, so this change is just to reduce boilerplate.