Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1664613002: Templatize GrNonAtomicRef (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Templatize GrNonAtomicRef Templatizes GrNonAtomicRef so it does not necessarily require a virtual destructor. This also gives us the flexibility to specialize how different types get deleted. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1664613002 Committed: https://skia.googlesource.com/skia/+/4833f39a41e7689db4922fdbb5c1b47ae55f7c8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M src/gpu/GrNonAtomicRef.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrBatch.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Chris Dalton
4 years, 10 months ago (2016-02-03 02:10:32 UTC) #3
joshualitt
On 2016/02/03 02:10:32, Chris Dalton wrote: lgtm
4 years, 10 months ago (2016-02-03 02:17:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664613002/1
4 years, 10 months ago (2016-02-03 06:22:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5767)
4 years, 10 months ago (2016-02-03 06:24:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664613002/1
4 years, 10 months ago (2016-02-03 06:32:55 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 06:46:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4833f39a41e7689db4922fdbb5c1b47ae55f7c8d

Powered by Google App Engine
This is Rietveld 408576698