Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1664293002: Add back UTF-32 for now and fix a MSVC build issue (Closed)

Created:
4 years, 10 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add back UTF-32 for now and fix a MSVC build issue See http://crbug.com/417850 for UTF-32 See http://bugs.icu-project.org/trac/ticket/12147 for C4275 warning from MSVC. BUG=575007 TEST=Layout tests fast/encoding/* TEST=MSVC does not emit C4275 warning any more R=jsbell@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/ce2d2fd0d3d3bada940bf6d592172ea3a61a4a82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -13 lines) Patch
M README.chromium View 2 chunks +8 lines, -4 lines 0 comments Download
A patches/utf32.patch View 1 chunk +54 lines, -0 lines 0 comments Download
M patches/vscomp.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M source/common/sharedobject.h View 1 chunk +1 line, -1 line 0 comments Download
M source/common/ucnv_bld.cpp View 4 chunks +1 line, -7 lines 0 comments Download
M source/common/ucnv_u32.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
jungshik at Google
Joshua, PTAL. I'm turning back on UTF-32 in ICU for now until I have a ...
4 years, 10 months ago (2016-02-04 20:02:13 UTC) #4
jsbell
lgtm
4 years, 10 months ago (2016-02-04 20:10:48 UTC) #5
jungshik at Google
4 years, 10 months ago (2016-02-04 21:22:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce2d2fd0d3d3bada940bf6d592172ea3a61a4a82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698