Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: patches/vscomp.patch

Issue 1664293002: Add back UTF-32 for now and fix a MSVC build issue (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « patches/utf32.patch ('k') | source/common/sharedobject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: patches/vscomp.patch
diff --git a/patches/vscomp.patch b/patches/vscomp.patch
index 22bbba4234ceda905531bb18c55e0e719976895a..de079f059876f839251ba78b0a27b96db884d57d 100644
--- a/patches/vscomp.patch
+++ b/patches/vscomp.patch
@@ -50,3 +50,16 @@ index e99670d..c9a3502 100644
char type[256];
Calendar::getCalendarTypeFromLocale(fLoc, type, UPRV_LENGTHOF(type), status);
if (U_FAILURE(status)) {
+diff --git a/source/common/sharedobject.h b/source/common/sharedobject.h
+index 4402869..e5062cc 100644
+--- a/source/common/sharedobject.h
++++ b/source/common/sharedobject.h
+@@ -21,7 +21,7 @@ U_NAMESPACE_BEGIN
+ * update cache metrics. No other part of ICU, except for SharedObject,
+ * should directly call the methods of this base class.
+ */
+-class UnifiedCacheBase : public UObject {
++class U_COMMON_API UnifiedCacheBase : public UObject {
+ public:
+ UnifiedCacheBase() { }
+
« no previous file with comments | « patches/utf32.patch ('k') | source/common/sharedobject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698