Using == instead of Equals for der::Input comparison.

net/der/input.h

Index: net/der/input.h
diff --git a/net/der/input.h b/net/der/input.h
index 9c3f5ca87a4ab47a7ced6ecf712a947ad5ab382a..121a9e0770a949c077bd5e6047a37b7b39c5dd2c 100644
--- a/net/der/input.h
+++ b/net/der/input.h
@@ -63,9 +63,6 @@ class NET_EXPORT_PRIVATE Input {
   // Returns the length in bytes of an Input's data.
   size_t Length() const { return len_; }
 
-  // Return true if the Input's data and |other|'s data are byte-wise equal.
-  bool Equals(const Input& other) const;
-
   // Returns a pointer to the Input's data. This method is marked as "unsafe"
   // because access to the Input's data should be done through ByteReader
   // instead. This method should only be used where using a ByteReader truly
@@ -91,6 +88,12 @@ class NET_EXPORT_PRIVATE Input {
   size_t len_;
 };
 
+// Return true if |lhs|'s data and |rhs|'s data are byte-wise equal.
+NET_EXPORT_PRIVATE bool operator==(const Input& lhs, const Input& rhs);

[eroman, 2016/02/04 19:43:42]

Any reason to choose a function rather than method on Input?

I don't really care either way, but I think it is more common in net code to
expose these as member functions.

[mattm, 2016/02/04 20:05:51]

See my reference above to the style guide. (I don't really feel strongly about
it, just think we should default to following the guide unless there's a reason
not to.)

+
+// Return true if |lhs|'s data and |rhs|'s data are not byte-wise equal.
+NET_EXPORT_PRIVATE bool operator!=(const Input& lhs, const Input& rhs);
+
 // Returns true if |lhs|'s data is lexicographically less than |rhs|'s data.
 NET_EXPORT_PRIVATE bool operator<(const Input& lhs, const Input& rhs);