Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: net/cert/internal/verify_name_match.cc

Issue 1664243002: Using == instead of Equals for der::Input comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using non-class equality. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_name_match.cc
diff --git a/net/cert/internal/verify_name_match.cc b/net/cert/internal/verify_name_match.cc
index 00d1fb5c113966afaa94fa356d40a0a53147ca52..16d8b780964bee7bbd5893deae12b544f4746268 100644
--- a/net/cert/internal/verify_name_match.cc
+++ b/net/cert/internal/verify_name_match.cc
@@ -289,7 +289,7 @@ bool VerifyValueMatch(const der::Tag a_tag,
if (a_tag != b_tag)
return false;
// All other types use binary comparison.
- return a_value.Equals(b_value);
+ return a_value == b_value;
}
struct AttributeTypeAndValue {
@@ -381,7 +381,7 @@ bool VerifyRdnMatch(der::Parser* a_parser, der::Parser* b_parser) {
b_type_and_values.begin();
for (; b_iter != b_type_and_values.end(); ++b_iter) {
const auto& b = *b_iter;
- if (a.type.Equals(b.type) &&
+ if (a.type == b.type &&
VerifyValueMatch(a.value_tag, a.value, b.value_tag, b.value)) {
break;
}
@@ -492,7 +492,7 @@ bool NameContainsEmailAddress(const der::Input& name_rdn_sequence,
return false;
for (const auto& type_and_value : type_and_values) {
- if (type_and_value.type.Equals(der::Input(kOidEmailAddress))) {
+ if (type_and_value.type == der::Input(kOidEmailAddress)) {
*contained_email_address = true;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698