net/cert/internal/test_helpers.cc - Issue 1664243002: Using == instead of Equals for der::Input comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/test_helpers.cc

Issue 1664243002: Using == instead of Equals for der::Input comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using non-class equality. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/internal/test_helpers.cc

diff --git a/net/cert/internal/test_helpers.cc b/net/cert/internal/test_helpers.cc

index 4194ae3e6a44665b2f05131160511d30e94dee65..71b9a26e90a69bd81cdd42e57d0b6c3ede3853d5 100644

--- a/net/cert/internal/test_helpers.cc

+++ b/net/cert/internal/test_helpers.cc

@@ -26,10 +26,6 @@ void PrintTo(const Input& data, ::std::ostream* os) {

*os << "[" << b64 << "]";

}

-bool operator==(const Input& a, const Input& b) {

- return a.Equals(b);

} // namespace der

der::Input SequenceValueFromString(const std::string* s) {

« net/cert/internal/test_helpers.h ('K') | « net/cert/internal/test_helpers.h ('k') | net/cert/internal/verify_certificate_chain.cc » ('j') | net/der/input.h » ('J')