Using == instead of Equals for der::Input comparison.

net/der/input.h

Index: net/der/input.h
diff --git a/net/der/input.h b/net/der/input.h
index 9c3f5ca87a4ab47a7ced6ecf712a947ad5ab382a..7a4c21c89d45653fb59ffe8576248a0dab755948 100644
--- a/net/der/input.h
+++ b/net/der/input.h
@@ -64,7 +64,10 @@ class NET_EXPORT_PRIVATE Input {
   size_t Length() const { return len_; }
 
   // Return true if the Input's data and |other|'s data are byte-wise equal.
-  bool Equals(const Input& other) const;
+  bool operator==(const Input& other) const;

[mattm, 2016/02/04 18:55:29]

The style guide said to: "Prefer to define non-modifying binary operators as
non-member functions. If a binary operator is defined as a class member,
implicit conversions will apply to the right-hand argument, but not the
left-hand one. It will confuse your users if a < b compiles but b < a doesn't."

Don't know how much it matters for Input though (and why the const std::string*
constructor is not explicit?)

[svaldez, 2016/02/04 19:11:00]

Done.

+
+  // Return true if the Input's data and |other|'s data are not byte-wise equal.
+  bool operator!=(const Input& other) const;
 
   // Returns a pointer to the Input's data. This method is marked as "unsafe"
   // because access to the Input's data should be done through ByteReader