Using == instead of Equals for der::Input comparison.

net/der/input.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DER_INPUT_H_
 #define NET_DER_INPUT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 46 matching lines @@
 
   // Creates an Input from a std::string. The lifetimes are a bit subtle when
   // using this function: The constructed Input is only valid so long as |s| is
   // still alive and not mutated.
   Input(const std::string* s);
 
   // Returns the length in bytes of an Input's data.
   size_t Length() const { return len_; }
 
   // Return true if the Input's data and |other|'s data are byte-wise equal.
-  bool Equals(const Input& other) const;
+  bool operator==(const Input& other) const;

[mattm, 2016/02/04 18:55:29]

The style guide said to: "Prefer to define non-modifying binary operators as
non-member functions. If a binary operator is defined as a class member,
implicit conversions will apply to the right-hand argument, but not the
left-hand one. It will confuse your users if a < b compiles but b < a doesn't."

Don't know how much it matters for Input though (and why the const std::string*
constructor is not explicit?)

[svaldez, 2016/02/04 19:11:00]

Done.

+
+  // Return true if the Input's data and |other|'s data are not byte-wise equal.
+  bool operator!=(const Input& other) const;
 
   // Returns a pointer to the Input's data. This method is marked as "unsafe"
   // because access to the Input's data should be done through ByteReader
   // instead. This method should only be used where using a ByteReader truly
   // is not an option.
   const uint8_t* UnsafeData() const { return data_; }
 
   // Returns a copy of the data represented by this object as a std::string.
   std::string AsString() const;
 
@@ skipping 98 matching lines @@
   explicit Mark(const uint8_t* ptr);
   Mark();
   const uint8_t* ptr_;
 };
 
 }  // namespace der
 
 }  // namespace net
 
 #endif  // NET_DER_INPUT_H_