Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: net/cert/internal/verify_certificate_chain.cc

Issue 1664243002: Using == instead of Equals for der::Input comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing missing !=. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_certificate_chain.cc
diff --git a/net/cert/internal/verify_certificate_chain.cc b/net/cert/internal/verify_certificate_chain.cc
index 524de925d3e2ce4036c91f3c4e63b82898eb4637..8fcb75f81508a9514889df2d1bd8dcf086bc9966 100644
--- a/net/cert/internal/verify_certificate_chain.cc
+++ b/net/cert/internal/verify_certificate_chain.cc
@@ -229,9 +229,8 @@ WARN_UNUSED_RESULT bool VerifySignatureAlgorithmsMatch(
// Ensure that the two DER-encoded signature algorithms are byte-for-byte
// equal, but make a compatibility concession for RSA with SHA1.
- return alg1_tlv.Equals(alg2_tlv) ||
- (IsRsaWithSha1SignatureAlgorithm(alg1_tlv) &&
- IsRsaWithSha1SignatureAlgorithm(alg2_tlv));
+ return alg1_tlv == alg2_tlv || (IsRsaWithSha1SignatureAlgorithm(alg1_tlv) &&
+ IsRsaWithSha1SignatureAlgorithm(alg2_tlv));
}
// This function corresponds to RFC 5280 section 6.1.3's "Basic Certificate

Powered by Google App Engine
This is Rietveld 408576698