Using == instead of Equals for der::Input comparison.

Using == instead of Equals for der::Input comparison.

BUG=

Committed: https://crrev.com/f3d07c445a49064851ca3885c3797d296dc4003a
Cr-Commit-Position: refs/heads/master@{#373635}

[svaldez, 2016-02-04 16:35:53]

svaldez@chromium.org changed reviewers:
+ eroman@chromium.org, mattm@chromium.org

[svaldez, 2016-02-04 16:35:53]

Splitting this out from the OCSP parsing work.

Using operator== instead of Equals allows us to use der::Inputs representing
OIDs as keys and allowing us to search for them when parsing Extensions and
other arrays.

[mattm, 2016-02-04 18:55:29]

https://codereview.chromium.org/1664243002/diff/20001/net/der/input.h
File net/der/input.h (right):

https://codereview.chromium.org/1664243002/diff/20001/net/der/input.h#newcode67
net/der/input.h:67: bool operator==(const Input& other) const;
The style guide said to: "Prefer to define non-modifying binary operators as
non-member functions. If a binary operator is defined as a class member,
implicit conversions will apply to the right-hand argument, but not the
left-hand one. It will confuse your users if a < b compiles but b < a doesn't."

Don't know how much it matters for Input though (and why the const std::string*
constructor is not explicit?)

[svaldez, 2016-02-04 19:11:00]

https://codereview.chromium.org/1664243002/diff/20001/net/der/input.h
File net/der/input.h (right):

https://codereview.chromium.org/1664243002/diff/20001/net/der/input.h#newcode67
net/der/input.h:67: bool operator==(const Input& other) const;
On 2016/02/04 18:55:29, mattm wrote:
> The style guide said to: "Prefer to define non-modifying binary operators as
> non-member functions. If a binary operator is defined as a class member,
> implicit conversions will apply to the right-hand argument, but not the
> left-hand one. It will confuse your users if a < b compiles but b < a
doesn't."
> 
> Don't know how much it matters for Input though (and why the const
std::string*
> constructor is not explicit?)

Done.

[mattm, 2016-02-04 19:23:00]

lgtm

[svaldez, 2016-02-04 19:23:20]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2016-02-04 19:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664243002/40001

[eroman, 2016-02-04 19:43:42]

lgtm

https://codereview.chromium.org/1664243002/diff/40001/net/cert/internal/test_...
File net/cert/internal/test_helpers.h (right):

https://codereview.chromium.org/1664243002/diff/40001/net/cert/internal/test_...
net/cert/internal/test_helpers.h:21: // These functions are used by GTest to
support EXPECT_EQ() for
These functions --> This function is used...

https://codereview.chromium.org/1664243002/diff/40001/net/der/input.h
File net/der/input.h (right):

https://codereview.chromium.org/1664243002/diff/40001/net/der/input.h#newcode92
net/der/input.h:92: NET_EXPORT_PRIVATE bool operator==(const Input& lhs, const
Input& rhs);
Any reason to choose a function rather than method on Input?

I don't really care either way, but I think it is more common in net code to
expose these as member functions.

[mattm, 2016-02-04 20:05:51]

https://codereview.chromium.org/1664243002/diff/40001/net/der/input.h
File net/der/input.h (right):

https://codereview.chromium.org/1664243002/diff/40001/net/der/input.h#newcode92
net/der/input.h:92: NET_EXPORT_PRIVATE bool operator==(const Input& lhs, const
Input& rhs);
On 2016/02/04 19:43:42, eroman wrote:
> Any reason to choose a function rather than method on Input?
> 
> I don't really care either way, but I think it is more common in net code to
> expose these as member functions.

See my reference above to the style guide. (I don't really feel strongly about
it, just think we should default to following the guide unless there's a reason
not to.)

[svaldez, 2016-02-04 20:20:39]

The CQ bit was unchecked by svaldez@chromium.org

[svaldez, 2016-02-04 20:22:10]

The CQ bit was checked by svaldez@chromium.org

[svaldez, 2016-02-04 20:22:11]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1664243002/#ps60001
(title: "Fixing comment.")

[commit-bot: I haz the power, 2016-02-04 20:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1664243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1664243002/60001

[commit-bot: I haz the power, 2016-02-04 22:08:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-04 22:09:29]

Description was changed from

==========
Using == instead of Equals for der::Input comparison.

BUG=
==========

to

==========
Using == instead of Equals for der::Input comparison.

BUG=

Committed: https://crrev.com/f3d07c445a49064851ca3885c3797d296dc4003a
Cr-Commit-Position: refs/heads/master@{#373635}
==========

[commit-bot: I haz the power, 2016-02-04 22:09:30]

Patchset 4 (id:??) landed as
https://crrev.com/f3d07c445a49064851ca3885c3797d296dc4003a
Cr-Commit-Position: refs/heads/master@{#373635}