Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664093002: CSS Typed OM: TransformComponent names match the spec (Closed)

Created:
4 years, 10 months ago by tridgell
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, rjwright, lawton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Typed OM: TransformComponent names match the spec Changed <type>TransformComponent.idl to <type.idl> Updated layout tests as appropriate (only naming). BUG=545318 Spec: https://drafts.css-houdini.org/css-typed-om/#transformcomponent Committed: https://crrev.com/8da24950ad8d720250957ad6436b308b6df0cc2a Cr-Commit-Position: refs/heads/master@{#374076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -184 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html View 2 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/scaleTransformComponent.html View 2 chunks +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/transformValue.html View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/Matrix.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.idl View 1 chunk +0 lines, -35 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/Perspective.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.idl View 1 chunk +0 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/Rotation.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.idl View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/Scale.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/ScaleTransformComponent.idl View 1 chunk +0 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/Skew.idl View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.idl View 1 chunk +0 lines, -11 lines 0 comments Download

Dependent Patchsets:

Issue 1648853002 Patch 100001

Messages

Total messages: 16 (8 generated)
tridgell
4 years, 10 months ago (2016-02-04 04:02:06 UTC) #2
meade_UTC10
lgtm
4 years, 10 months ago (2016-02-04 06:43:44 UTC) #5
Timothy Loh
lgtm
4 years, 10 months ago (2016-02-07 23:55:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664093002/1
4 years, 10 months ago (2016-02-07 23:56:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/142102)
4 years, 10 months ago (2016-02-08 01:00:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664093002/1
4 years, 10 months ago (2016-02-08 01:21:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 02:29:34 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 02:30:13 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8da24950ad8d720250957ad6436b308b6df0cc2a
Cr-Commit-Position: refs/heads/master@{#374076}

Powered by Google App Engine
This is Rietveld 408576698