Add product mode:

runtime/vm/symbols.cc

Index: runtime/vm/symbols.cc
diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc
index bee034f3ae5f97742f67c29e82c4304895a295a0..a56b5037acc94a78ad590ed85556b69266bd8ac3 100644
--- a/runtime/vm/symbols.cc
+++ b/runtime/vm/symbols.cc
@@ -36,7 +36,8 @@ PREDEFINED_SYMBOLS_LIST(DEFINE_SYMBOL_LITERAL)
 #undef DEFINE_KEYWORD_SYMBOL_INDEX
 };
 
-DEFINE_FLAG(bool, dump_symbol_stats, false, "Dump symbol table statistics");
+PRODUCT_FLAG(false, bool, dump_symbol_stats, false,
+             "Dump symbol table statistics");

[siva, 2016/02/03 20:33:51]

Do you anticipate the product value being different from the default value in
some cases?

I was wondering if it is possible to set the default values to be what we want
in a product build.

Maybe the service isolate related parameters could potentially have different
values.

Could we use macros like
#define kProductTrue true
#define kProductFalse false
#define kDefaultTrue true
#define kDefaultFalse false

PRODUCT_FLAG(kProductFalse, bool dump_symbol_stats, kDefaultFalse...
to make it more readable as to which bool refers to product vs default

 
 
 RawString* StringFrom(const uint8_t* data, intptr_t len, Heap::Space space) {