Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1661933002: Remove incorrect dependency of components_unittests on test_support_ios. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect dependency of components_unittests on test_support_ios. Since fake_profile_oauth2_token_service_ios_provider.{cc,h} have been moved into components/signin/ios/ (http://crrev.com/1218073006) this dependency is unnecessary, so remove it. BUG=None Committed: https://crrev.com/3f67d1585ca5d159a01c4cfc9d2a1464333e8d18 Cr-Commit-Position: refs/heads/master@{#373229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/core/browser/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-03 12:37:44 UTC) #2
droger
lgtm
4 years, 10 months ago (2016-02-03 13:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1661933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1661933002/1
4 years, 10 months ago (2016-02-03 13:43:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 13:51:53 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 13:52:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f67d1585ca5d159a01c4cfc9d2a1464333e8d18
Cr-Commit-Position: refs/heads/master@{#373229}

Powered by Google App Engine
This is Rietveld 408576698