Re-land: Fix race in UseNewEDK().

Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense to destroy that instance since it's a cache of a command line flag.

BUG=539315
Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}

Committed: https://crrev.com/6be610508ebbc1787e959e741861f6eecff02c8d
Cr-Commit-Position: refs/heads/master@{#373176}

[Anand Mistry (off Chromium), 2016-02-03 02:17:33]

amistry@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-02-03 02:39:55]

Did you change anything or land some prerequisite? If so, mention that in the cl
description. Other than that rs-lgtm assuming you've checked that that test is
now happy in official builds

[Anand Mistry (off Chromium), 2016-02-03 02:48:22]

Description was changed from

==========
Re-land: Fix race in UseNewEDK().

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}
==========

to

==========
Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to
avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense
to destroy that instance since it's a cache of a command line flag.

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}
==========

[Anand Mistry (off Chromium), 2016-02-03 02:54:29]

On 2016/02/03 02:39:55, Nico wrote:
> Did you change anything or land some prerequisite? If so, mention that in the
cl
> description. Other than that rs-lgtm assuming you've checked that that test is
> now happy in official builds

See description. I've checked the browser_tests repro and verified that way. It
doesn't look like we have an official trybot.

As for the cause, I'm "fixing" it in
https://codereview.chromium.org/1661673003/, but I'm sceptical that's what we
actually want.

[Nico, 2016-02-03 03:25:01]

On 2016/02/03 02:54:29, Anand Mistry wrote:
> On 2016/02/03 02:39:55, Nico wrote:
> > Did you change anything or land some prerequisite? If so, mention that in
the
> cl
> > description. Other than that rs-lgtm assuming you've checked that that test
is
> > now happy in official builds
> 
> See description. I've checked the browser_tests repro and verified that way.
It
> doesn't look like we have an official trybot.
> 
> As for the cause, I'm "fixing" it in
> https://codereview.chromium.org/1661673003/, but I'm sceptical that's what we
> actually want.

Thanks!

(For the future: One common technique for relanding is to upload the original
change as patch set 2. Then it's easy to see what changed)

[Anand Mistry (off Chromium), 2016-02-03 03:38:30]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-02-03 03:39:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663693002/1

[commit-bot: I haz the power, 2016-02-03 04:50:13]

Description was changed from

==========
Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to
avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense
to destroy that instance since it's a cache of a command line flag.

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}
==========

to

==========
Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to
avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense
to destroy that instance since it's a cache of a command line flag.

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}
==========

[commit-bot: I haz the power, 2016-02-03 04:50:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-03 04:51:18]

Description was changed from

==========
Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to
avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense
to destroy that instance since it's a cache of a command line flag.

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}
==========

to

==========
Re-land: Fix race in UseNewEDK().

The difference with this re-land is that it changes LazyInstance to be leaky to
avoid a recursive lock acquisition in AtExitManager. It also doesn't make sense
to destroy that instance since it's a cache of a command line flag.

BUG=539315

Review URL: https://codereview.chromium.org/1646223002

Cr-Commit-Position: refs/heads/master@{#372501}

Committed: https://crrev.com/6be610508ebbc1787e959e741861f6eecff02c8d
Cr-Commit-Position: refs/heads/master@{#373176}
==========

[commit-bot: I haz the power, 2016-02-03 04:51:19]

Patchset 1 (id:??) landed as
https://crrev.com/6be610508ebbc1787e959e741861f6eecff02c8d
Cr-Commit-Position: refs/heads/master@{#373176}