Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1646223002: Fix race in UseNewEDK(). (Closed)

Created:
4 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race in UseNewEDK(). BUG=539315 Committed: https://crrev.com/189f17c6d5206a9c0ef6af99f598079f637579af Cr-Commit-Position: refs/heads/master@{#372501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/entrypoints.cc View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
4 years, 10 months ago (2016-01-29 05:28:34 UTC) #2
jam
lgtm
4 years, 10 months ago (2016-01-29 17:05:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646223002/1
4 years, 10 months ago (2016-01-29 22:28:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 01:07:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/189f17c6d5206a9c0ef6af99f598079f637579af Cr-Commit-Position: refs/heads/master@{#372501}
4 years, 10 months ago (2016-01-30 01:08:18 UTC) #8
Nico
4 years, 10 months ago (2016-02-02 16:27:53 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1658233002/ by thakis@chromium.org.

The reason for reverting is: Broke some tests in official builds, see
http://crbug.com/583040 (comment 9 has repro steps).

Powered by Google App Engine
This is Rietveld 408576698