Issue 1663463002: Manually fetch favicons after hash changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1663463002: Manually fetch favicons after hash changes. (Closed)

Created:
4 years, 10 months ago by kkhorimoto

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

Manually fetch favicons after hash changes. Hash changes don't trigger |-didFinishNavigation|, so favicons must be fetched manually. BUG=531267 Review URL: https://codereview.chromium.org/1360543004 Cr-Commit-Position: refs/heads/master@{#372731} (cherry picked from commit 61b25a293cc34eea68335f35cbc0822b824ab3f6) Committed: https://chromium.googlesource.com/chromium/src/+/cbb0ba3c8163792aec3504ca268b42a1849d8efa

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	ios/web/web_state/js/resources/core.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ios/web/web_state/js/resources/core_dynamic_ui.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ios/web/web_state/js/resources/core_dynamic_wk.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ios/web/web_state/ui/crw_web_controller.mm	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

kkhorimoto

4 years, 10 months ago (2016-02-02 19:40:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cbb0ba3c8163792aec3504ca268b42a1849d8efa.