Manually fetch favicons after hash changes.

Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267
Committed: https://crrev.com/61b25a293cc34eea68335f35cbc0822b824ab3f6
Cr-Commit-Position: refs/heads/master@{#372731}

[kkhorimoto, 2015-09-21 21:12:57]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, stuartmorgan@chromium.org

[Eugene But (OOO till 7-30), 2015-09-21 21:32:43]

https://codereview.chromium.org/1360543004/diff/1/ios/web/web_state/ui/crw_ui...
File ios/web/web_state/ui/crw_ui_web_view_web_controller.mm (right):

https://codereview.chromium.org/1360543004/diff/1/ios/web/web_state/ui/crw_ui...
ios/web/web_state/ui/crw_ui_web_view_web_controller.mm:828:
@"__gCrWeb.message.invokeOnHost("
This approach is very fragile and will break if f.e. invokeOnHost will be
renamed. How about adding a public function to web JS?

[kkhorimoto, 2016-01-30 00:46:56]

Description was changed from

==========
Fetch favicons from |-webPageChanged|.

This fixes the bug where hash changes on UIWebView did not trigger a
favicon fetch.

BUG=531267
==========

to

==========
Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267
==========

[kkhorimoto, 2016-01-30 00:47:01]

https://codereview.chromium.org/1360543004/diff/1/ios/web/web_state/ui/crw_ui...
File ios/web/web_state/ui/crw_ui_web_view_web_controller.mm (right):

https://codereview.chromium.org/1360543004/diff/1/ios/web/web_state/ui/crw_ui...
ios/web/web_state/ui/crw_ui_web_view_web_controller.mm:828:
@"__gCrWeb.message.invokeOnHost("
On 2015/09/21 21:32:43, eugenebut wrote:
> This approach is very fragile and will break if f.e. invokeOnHost will be
> renamed. How about adding a public function to web JS?

Done.

[Eugene But (OOO till 7-30), 2016-02-01 15:55:37]

lgtm

https://codereview.chromium.org/1360543004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1360543004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2432: JSONResultHandler:nil];
s/JSONResultHandler/stringResultHandler/

JSONResultHandler is stringResultHandler + conversion code, which you don't need
here.

[kkhorimoto, 2016-02-01 19:32:52]

https://codereview.chromium.org/1360543004/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/1360543004/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2432: JSONResultHandler:nil];
On 2016/02/01 15:55:37, eugenebut wrote:
> s/JSONResultHandler/stringResultHandler/
> 
> JSONResultHandler is stringResultHandler + conversion code, which you don't
need
> here. 

Done.

[kkhorimoto, 2016-02-01 19:32:55]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-02-01 19:32:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1360543004/#ps40001
(title: "JSON handler => string handler")

[commit-bot: I haz the power, 2016-02-01 19:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360543004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360543004/40001

[commit-bot: I haz the power, 2016-02-01 20:06:24]

Description was changed from

==========
Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267
==========

to

==========
Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267
==========

[commit-bot: I haz the power, 2016-02-01 20:06:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-01 20:07:30]

Description was changed from

==========
Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267
==========

to

==========
Manually fetch favicons after hash changes.

Hash changes don't trigger |-didFinishNavigation|, so favicons
must be fetched manually.

BUG=531267

Committed: https://crrev.com/61b25a293cc34eea68335f35cbc0822b824ab3f6
Cr-Commit-Position: refs/heads/master@{#372731}
==========

[commit-bot: I haz the power, 2016-02-01 20:07:32]

Patchset 3 (id:??) landed as
https://crrev.com/61b25a293cc34eea68335f35cbc0822b824ab3f6
Cr-Commit-Position: refs/heads/master@{#372731}