Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5815)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 16632009: Set AllowOverlappingViews for history overlay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 9c637694dab9e74dfe3286c27a0f4d2cbed505b8..1dc4ce8dd0f85b75c7da7643a568e71da250d6ed 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1992,6 +1992,16 @@ willAnimateFromState:(BookmarkBar::State)oldState
[self updateAllowOverlappingViews:[self inPresentationMode]];
}
+- (void)onHistoryOverlayShown {
+ ++historyOverlayCount_;
Robert Sesek 2013/06/10 20:30:35 Why do we need to count them?
sail 2013/06/10 20:56:01 The window controller instance is referenced by mu
Robert Sesek 2013/06/10 20:59:28 I guess it depends on what the invariant is. It se
sail 2013/06/10 22:21:07 I verified that the count can be greater than 1. F
+ [self updateAllowOverlappingViews:[self inPresentationMode]];
+}
+
+- (void)onHistoryOverlayHidden {
+ --historyOverlayCount_;
+ [self updateAllowOverlappingViews:[self inPresentationMode]];
+}
+
@end // @implementation BrowserWindowController

Powered by Google App Engine
This is Rietveld 408576698