Set AllowOverlappingViews for history overlay

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 
 #include "base/command_line.h"
@@ skipping 1974 matching lines @@
   [toolbarController_ setDividerOpacity:[self toolbarDividerOpacity]];
   [self updateContentOffsets];
   [self updateSubviewZOrder:[self inPresentationMode]];
   [self updateInfoBarTipVisibility];
 }
 
 - (void)onFindBarVisibilityChanged {
   [self updateAllowOverlappingViews:[self inPresentationMode]];
 }
 
+- (void)onHistoryOverlayShown {
+  ++historyOverlayCount_;

[Robert Sesek, 2013/06/10 20:30:35]

Why do we need to count them?

[sail, 2013/06/10 20:56:01]

The window controller instance is referenced by multiple RWHVs. In practice
there won't be more than one though. I can make this a BOOL with a DCHECK if you
like.

[Robert Sesek, 2013/06/10 20:59:28]

I guess it depends on what the invariant is. It seems odd to count if it only
ever goes to 1.

[sail, 2013/06/10 22:21:07]

I verified that the count can be greater than 1. For example:
 - swipe to go back
 - immediately swipe to go forward
Because there's a delay before the overlay is hidden you can have two overlays
at the same time.

I believe you can also reproduce this with multiple tabs.

+  [self updateAllowOverlappingViews:[self inPresentationMode]];
+}
+
+- (void)onHistoryOverlayHidden {
+  --historyOverlayCount_;
+  [self updateAllowOverlappingViews:[self inPresentationMode]];
+}
+
 @end  // @implementation BrowserWindowController
 
 
 @implementation BrowserWindowController(Fullscreen)
 
 - (void)handleLionToggleFullscreen {
   DCHECK(base::mac::IsOSLionOrLater());
   chrome::ExecuteCommand(browser_.get(), IDC_FULLSCREEN);
 }
 
@@ skipping 241 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 @end  // @implementation BrowserWindowController(WindowType)