Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1663053005: Reland of move --no-sandbox flag from command line for telemetry (Closed)

Created:
4 years, 10 months ago by ssid
Modified:
4 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sandbox
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move --no-sandbox flag from command line for telemetry (patchset #1 id:1 of https://codereview.chromium.org/1659033002/ ) Reason for revert: All the bots that failed were running Precise and have been moved to Trusty now. crbug.com/583408. Original issue's description: > Revert of Remove --no-sandbox flag from command line for telemetry (patchset #4 id:60001 of https://codereview.chromium.org/1584583003/ ) > > Reason for revert: > MemoryInfra benchmarks are failing after this CL. > crbug.com/583101 > > Original issue's description: > > Remove --no-sandbox flag from command line for telemetry > > > > Now that the browser is able to dump for child processes the > > --no-sandbox flag is not required for getting memory statistics. So, > > this is removed form the telemetry benchmarks. > > > > BUG=461788 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect > > > > Committed: https://crrev.com/2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71 > > Cr-Commit-Position: refs/heads/master@{#372667} > > TBR=primiano@chromium.org,nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=461788 > > Committed: https://crrev.com/203ca2a0729aa404fc724583a360377a3793cae4 > Cr-Commit-Position: refs/heads/master@{#372927} CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect TBR=primiano@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=461788 Committed: https://crrev.com/0ef5d829a8b875ab67abc58840aa4a01e6a88df9 Cr-Commit-Position: refs/heads/master@{#373540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/perf/benchmarks/memory_infra.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ssid
Created Reland of move --no-sandbox flag from command line for telemetry
4 years, 10 months ago (2016-02-04 11:48:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053005/1
4 years, 10 months ago (2016-02-04 11:50:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 13:13:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663053005/1
4 years, 10 months ago (2016-02-04 13:16:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 15:34:57 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ef5d829a8b875ab67abc58840aa4a01e6a88df9 Cr-Commit-Position: refs/heads/master@{#373540}
4 years, 10 months ago (2016-02-04 15:36:04 UTC) #13
ssid
4 years, 10 months ago (2016-02-10 00:58:08 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1683003002/ by ssid@chromium.org.

The reason for reverting is: crbug.com/583408 got re-opened.

BUG=585161, 584634.

Powered by Google App Engine
This is Rietveld 408576698