Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: tools/perf/benchmarks/oortonline.py

Issue 1663053005: Reland of move --no-sandbox flag from command line for telemetry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sandbox
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import page_sets 5 import page_sets
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.page import page_test 9 from telemetry.page import page_test
10 from telemetry.value import scalar 10 from telemetry.value import scalar
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 """OortOnline benchmark that measures WebGL and V8 performance. 54 """OortOnline benchmark that measures WebGL and V8 performance.
55 URL: http://oortonline.gl/#run 55 URL: http://oortonline.gl/#run
56 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html 56 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html
57 """ 57 """
58 58
59 def SetExtraBrowserOptions(self, options): 59 def SetExtraBrowserOptions(self, options):
60 options.AppendExtraBrowserArgs([ 60 options.AppendExtraBrowserArgs([
61 # TODO(perezju): Temporary workaround to disable periodic memory dumps. 61 # TODO(perezju): Temporary workaround to disable periodic memory dumps.
62 # See: http://crbug.com/513692 62 # See: http://crbug.com/513692
63 '--enable-memory-benchmarking', 63 '--enable-memory-benchmarking',
64 # TODO(ssid): Remove this flag after fixing http://crbug.com/461788.
65 '--no-sandbox'
66 ]) 64 ])
67 65
68 def CreateStorySet(self, options): 66 def CreateStorySet(self, options):
69 return page_sets.OortOnlineTBMPageSet() 67 return page_sets.OortOnlineTBMPageSet()
70 68
71 def CreateTimelineBasedMeasurementOptions(self): 69 def CreateTimelineBasedMeasurementOptions(self):
72 v8_gc_latency_categories = [ 70 v8_gc_latency_categories = [
73 'blink.console', 'renderer.scheduler', 'v8', 'webkit.console'] 71 'blink.console', 'renderer.scheduler', 'v8', 'webkit.console']
74 smoothness_categories = [ 72 smoothness_categories = [
75 'webkit.console', 'blink.console', 'benchmark', 'trace_event_overhead'] 73 'webkit.console', 'blink.console', 'benchmark', 'trace_event_overhead']
(...skipping 12 matching lines...) Expand all
88 @classmethod 86 @classmethod
89 def Name(cls): 87 def Name(cls):
90 return 'oortonline_tbm' 88 return 'oortonline_tbm'
91 89
92 @classmethod 90 @classmethod
93 def ValueCanBeAddedPredicate(cls, value, is_first_result): 91 def ValueCanBeAddedPredicate(cls, value, is_first_result):
94 if value.tir_label in ['Begin', 'End']: 92 if value.tir_label in ['Begin', 'End']:
95 return value.name.startswith('memory_') and 'v8_renderer' in value.name 93 return value.name.startswith('memory_') and 'v8_renderer' in value.name
96 else: 94 else:
97 return value.tir_label == 'Running' 95 return value.tir_label == 'Running'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698