Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1663033002: Revert of [Courgette] Add ELF-ARM test binary. (Closed)

Created:
4 years, 10 months ago by vabr (Chromium)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Courgette] Add ELF-ARM test binary. (patchset #5 id:80001 of https://codereview.chromium.org/1662633002/ ) Reason for revert: Broke checkperms, see http://crbug.com/579206#c9. Original issue's description: > [Courgette] Add ELF-ARM test binary. > > Adding ELF ARM (v7) test binary that fails Courgette-dis. The binary > has a non-code .bad section that if parsed, yields an invalid RVA that > fails check latter. The commands to create the file are: > > echo -e 'int main(){return 0;}' | arm-linux-gnueabi-g++ -xc++ -march=armv7-a -mtune=generic-armv7-a - > echo '00 20 00 0A 00 00 00 00' | xxd -r -p - bad_section > arm-linux-gnueabihf-objcopy a.out elf-armv7 --add-section .bad=bad_section > rm a.out bad_section > > The problematic code is > 00000000: 00 20 00 0A => beq loc_00008008 > > The target RVA (00008008) is valid, but the site RVA (00000000) is bad. > > BUG=579206 > NOPRESUBMIT=true > > Committed: https://crrev.com/5dd21d43c6da1cd24f80131811158fada2fc8610 > Cr-Commit-Position: refs/heads/master@{#373162} TBR=wfh@chromium.org,huangs@google.com,huangs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579206 Committed: https://crrev.com/702966771d12625216a70220e84c8c703596f654 Cr-Commit-Position: refs/heads/master@{#373210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
D courgette/testdata/elf-armv7 View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
vabr (Chromium)
Created Revert of [Courgette] Add ELF-ARM test binary.
4 years, 10 months ago (2016-02-03 10:26:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663033002/1
4 years, 10 months ago (2016-02-03 10:26:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 10:27:24 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:28:44 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/702966771d12625216a70220e84c8c703596f654
Cr-Commit-Position: refs/heads/master@{#373210}

Powered by Google App Engine
This is Rietveld 408576698