[Release] Automatically notify mailing list on a pending merge

[Release] Automatically notify mailing list on a pending merge

With the combination of the WATCHLISTS feature and
create_release.py it is possible to notify the
mailing list v8-merges@googlegroups.com on pending
merges.

On master this notification is deactivated.

R=machenbach@chromium.org
NOTRY=true

Committed: https://crrev.com/ccf47c4d30d95e2f57927251bab1f3f143f665fc
Cr-Commit-Position: refs/heads/master@{#33719}

[Michael Hablich, 2016-02-03 15:20:52]

https://codereview.chromium.org/1663003003/diff/1/tools/release/common_includ...
File tools/release/common_includes.py (right):

https://codereview.chromium.org/1663003003/diff/1/tools/release/common_includ...
tools/release/common_includes.py:53: WATCHLISTS_FILE = "WATCHLISTS"
Moved it to this file because every other file path is also located here. And I
need it for the tests.

[Michael Achenbach, 2016-02-04 08:19:41]

lgtm - some suggestions

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts.py
File tools/release/test_scripts.py (right):

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts....
tools/release/test_scripts.py:401: f.write("# 'v8-merges@googlegroups.com',")
Please add the same whitespace as in the original file and make sure the regexps
still apply. You'd also need '\n' in the end of each line. Generally I find
multi-line strings in python more readable with """-strings (optionally with
local var):

  f.write("""
  'merges': [
    # Only enabled on branches created with tools/release/create_release.py
    # 'v8-merges@googlegroups.com',
  ],""")

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts....
tools/release/test_scripts.py:924: self.assertTrue(
optional: You could add an assert here to check that your file has the right
content on commit. And rename the method to something more general, i.e. just
CheckCommit.

[Michael Hablich, 2016-02-04 09:01:22]

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts.py
File tools/release/test_scripts.py (right):

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts....
tools/release/test_scripts.py:401: f.write("# 'v8-merges@googlegroups.com',")
On 2016/02/04 08:19:41, Michael Achenbach wrote:
> Please add the same whitespace as in the original file and make sure the
regexps
> still apply. You'd also need '\n' in the end of each line. Generally I find
> multi-line strings in python more readable with """-strings (optionally with
> local var):
> 
>   f.write("""
>   'merges': [
>     # Only enabled on branches created with tools/release/create_release.py
>     # mailto:,
>   ],""")

Ack and done. Just copied the style in the method above.

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts....
tools/release/test_scripts.py:924: self.assertTrue(
On 2016/02/04 08:19:41, Michael Achenbach wrote:
> optional: You could add an assert here to check that your file has the right
> content on commit. And rename the method to something more general, i.e. just
> CheckCommit.

Done. Added it to the bottom after all the work was done. Makes more sense.

[Michael Hablich, 2016-02-04 09:01:28]

The CQ bit was checked by hablich@chromium.org

[Michael Hablich, 2016-02-04 09:01:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1663003003/#ps20001
(title: "Tweaked the tests")

[commit-bot: I haz the power, 2016-02-04 09:01:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663003003/20001

[commit-bot: I haz the power, 2016-02-04 09:02:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-04 09:03:23]

Description was changed from

==========
[Release] Automatically notify mailing list on a pending merge

With the combination of the WATCHLISTS feature and
create_release.py it is possible to notify the
mailing list v8-merges@googlegroups.com on pending
merges.

On master this notification is deactivated.

R=machenbach@chromium.org
NOTRY=true
==========

to

==========
[Release] Automatically notify mailing list on a pending merge

With the combination of the WATCHLISTS feature and
create_release.py it is possible to notify the
mailing list v8-merges@googlegroups.com on pending
merges.

On master this notification is deactivated.

R=machenbach@chromium.org
NOTRY=true

Committed: https://crrev.com/ccf47c4d30d95e2f57927251bab1f3f143f665fc
Cr-Commit-Position: refs/heads/master@{#33719}
==========

[commit-bot: I haz the power, 2016-02-04 09:03:24]

Patchset 2 (id:??) landed as
https://crrev.com/ccf47c4d30d95e2f57927251bab1f3f143f665fc
Cr-Commit-Position: refs/heads/master@{#33719}

[Michael Achenbach, 2016-02-04 09:28:45]

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts.py
File tools/release/test_scripts.py (right):

https://codereview.chromium.org/1663003003/diff/1/tools/release/test_scripts....
tools/release/test_scripts.py:924: self.assertTrue(
On 2016/02/04 09:01:22, Hablich wrote:
> On 2016/02/04 08:19:41, Michael Achenbach wrote:
> > optional: You could add an assert here to check that your file has the right
> > content on commit. And rename the method to something more general, i.e.
just
> > CheckCommit.
> 
> Done. Added it to the bottom after all the work was done. Makes more sense.

Makes only sense because the tests are incorrect (insufficient). They don't mock
the side effects of the "git checkout master" command properly. Otherwise there
would be no changes left in the end. But anyways, these tests are messy...
there's a similar comment at the asserts that I added. Which are also wrong...