Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: tools/release/create_release.py

Issue 1663003003: [Release] Automatically notify mailing list on a pending merge (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaked the tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/release/common_includes.py ('k') | tools/release/test_scripts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/create_release.py
diff --git a/tools/release/create_release.py b/tools/release/create_release.py
index 3bbb50e491aa5bc175d747f3af996a8c4236226d..7477ea1461f5ebc8b10de654fd7136033a8292b4 100755
--- a/tools/release/create_release.py
+++ b/tools/release/create_release.py
@@ -11,7 +11,6 @@ import urllib2
from common_includes import *
-
class Preparation(Step):
MESSAGE = "Preparation."
@@ -164,6 +163,7 @@ class MakeBranch(Step):
self.Git("checkout -b work-branch %s" % self["push_hash"])
self.GitCheckoutFile(CHANGELOG_FILE, self["latest_version"])
self.GitCheckoutFile(VERSION_FILE, self["latest_version"])
+ self.GitCheckoutFile(WATCHLISTS_FILE, self["latest_version"])
class AddChangeLog(Step):
@@ -183,6 +183,19 @@ class SetVersion(Step):
self.SetVersion(os.path.join(self.default_cwd, VERSION_FILE), "new_")
+class EnableMergeWatchlist(Step):
+ MESSAGE = "Enable watchlist entry for merge notifications."
+
+ def RunStep(self):
+ old_watchlist_content = FileToText(os.path.join(self.default_cwd,
+ WATCHLISTS_FILE))
+ new_watchlist_content = re.sub("(# 'v8-merges@googlegroups\.com',)",
+ "'v8-merges@googlegroups.com',",
+ old_watchlist_content)
+ TextToFile(new_watchlist_content, os.path.join(self.default_cwd,
+ WATCHLISTS_FILE))
+
+
class CommitBranch(Step):
MESSAGE = "Commit version and changelog to new branch."
@@ -288,6 +301,7 @@ class CreateRelease(ScriptsBase):
MakeBranch,
AddChangeLog,
SetVersion,
+ EnableMergeWatchlist,
CommitBranch,
PushBranch,
TagRevision,
« no previous file with comments | « tools/release/common_includes.py ('k') | tools/release/test_scripts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698