Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1662933003: Convert scroll anchoring flag to runtime-enabled feature. (Closed)

Created:
4 years, 10 months ago by skobes
Modified:
4 years, 10 months ago
Reviewers:
esprehn, no sievers, ojan
CC:
esprehn, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert scroll anchoring flag to runtime-enabled feature. This has several advantages over WebSettings, described in the review thread on http://crrev.com/1647793002. Scroll anchoring is now enabled by --enable-blink-features=ScrollAnchoring instead of --enable-scroll-anchoring. BUG=558575 Committed: https://crrev.com/8d38067475f24e4d12929d53b7e474eacfe7fee4 Cr-Commit-Position: refs/heads/master@{#373715}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
skobes
4 years, 10 months ago (2016-02-03 06:18:24 UTC) #2
ojan
lgtm
4 years, 10 months ago (2016-02-03 07:12:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662933003/1
4 years, 10 months ago (2016-02-03 07:12:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/142007)
4 years, 10 months ago (2016-02-03 07:21:14 UTC) #7
skobes
+sievers for content/OWNERS
4 years, 10 months ago (2016-02-03 18:25:38 UTC) #9
skobes
+esprehn for web and platform OWNERS
4 years, 10 months ago (2016-02-03 18:29:09 UTC) #11
no sievers
On 2016/02/03 18:25:38, skobes wrote: > +sievers for content/OWNERS lgtm
4 years, 10 months ago (2016-02-03 18:55:48 UTC) #12
esprehn
lgtm
4 years, 10 months ago (2016-02-04 23:35:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662933003/1
4 years, 10 months ago (2016-02-04 23:59:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/18620) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-05 00:07:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662933003/20001
4 years, 10 months ago (2016-02-05 00:10:19 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 01:55:50 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 01:56:52 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d38067475f24e4d12929d53b7e474eacfe7fee4
Cr-Commit-Position: refs/heads/master@{#373715}

Powered by Google App Engine
This is Rietveld 408576698