third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp - Issue 1662933003: Convert scroll anchoring flag to runtime-enabled feature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Issue 1662933003: Convert scroll anchoring flag to runtime-enabled feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Settings.in ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp b/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

index 26262fa8ab13ed3a4244d3cdb5119afce1e0a3d5..d76d18c14eaaea59beab3c1af1448bd9a3267691 100644

--- a/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

+++ b/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

@@ -8,13 +8,10 @@

namespace blink {

-static void enableScrollAnchoring(Settings& settings)

- settings.setScrollAnchoringEnabled(true);

class ScrollAnchorTest : public RenderingTest {

- FrameSettingOverrideFunction settingOverrider() const override { return enableScrollAnchoring; }

+public:

+ ScrollAnchorTest() { RuntimeEnabledFeatures::setScrollAnchoringEnabled(true); }

+ ~ScrollAnchorTest() { RuntimeEnabledFeatures::setScrollAnchoringEnabled(false); }

};

TEST_F(ScrollAnchorTest, Basic)

« no previous file with comments | « third_party/WebKit/Source/core/frame/Settings.in ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »